Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Import Error on Data Type Change for Non-URL Values in Columns #3512

Open
ghislaineguerin opened this issue Mar 25, 2024 · 3 comments · May be fixed by #3566
Open

Data Import Error on Data Type Change for Non-URL Values in Columns #3512

ghislaineguerin opened this issue Mar 25, 2024 · 3 comments · May be fixed by #3566
Labels
needs: troubleshooting Issues that we can't reproduce or need to investigate further before picking a course of action type: bug Something isn't working work: backend Related to Python, Django, and simple SQL work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@ghislaineguerin
Copy link
Contributor

Description

In data import, if a column contains non-url values, such as the following:
image

Attempting to update the data type under these circumstances results in a crash, accompanied by the following error message:
image

Expected behavior

When attempting a data type change for such a column, the operation should either complete successfully, or a clear notification should be provided, indicating that the data type change cannot be executed.

@ghislaineguerin ghislaineguerin added type: bug Something isn't working needs: triage This issue has not yet been reviewed by a maintainer labels Mar 25, 2024
@kgodey kgodey added work: backend Related to Python, Django, and simple SQL work: frontend Related to frontend code in the mathesar_ui directory needs: troubleshooting Issues that we can't reproduce or need to investigate further before picking a course of action and removed needs: triage This issue has not yet been reviewed by a maintainer labels Mar 26, 2024
@kgodey kgodey added this to the v0.1.7 milestone Mar 26, 2024
@kgodey kgodey modified the milestones: v0.1.7, Beta Apr 3, 2024
@hitenvidhani
Copy link
Contributor

hitenvidhani commented May 4, 2024

Found a similar error [Video], is this behaviour expected or we want to show a clear warning message here for the user to understand?

@hitenvidhani hitenvidhani linked a pull request May 4, 2024 that will close this issue
7 tasks
@kgodey
Copy link
Contributor

kgodey commented May 11, 2024

Tagging @seancolsen to take a look at @hitenvidhani's comment.

@seancolsen
Copy link
Contributor

@hitenvidhani I agree it would be nice to improve the error message show in your attached video. Please open a separate ticket to track that though. It's a different issue than the one described here, and I don't want to add confusion to this thread. In general, please err on the side of opening new tickets for things like this, or ask in Matrix in cases where you're not sure if something warrants a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: troubleshooting Issues that we can't reproduce or need to investigate further before picking a course of action type: bug Something isn't working work: backend Related to Python, Django, and simple SQL work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants