Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: misuse of unsafe vector.GetStringAt #16235

Open
1 task done
XuPeng-SH opened this issue May 20, 2024 · 7 comments
Open
1 task done

[Bug]: misuse of unsafe vector.GetStringAt #16235

XuPeng-SH opened this issue May 20, 2024 · 7 comments
Assignees
@XuPeng-SH
Labels
kind/bug Something isn't working severity/s0 Extreme impact: Cause the application to break down and seriously affect the use
Milestone
1.3.0

Comments

@XuPeng-SH
Copy link
Contributor

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Branch Name

main,1.2-dev

Commit ID

latest

Other Environment Information

- Hardware parameters:
- OS type:
- Others:

Actual Behavior

vector.GetStringAt is unsafe and it is misused in some places.

Expected Behavior

No response

Steps to Reproduce

Read code

Additional information

No response
@XuPeng-SH XuPeng-SH added kind/bug Something isn't working needs-triage labels May 20, 2024
@XuPeng-SH XuPeng-SH added the severity/s0 Extreme impact: Cause the application to break down and seriously affect the use label May 20, 2024
@matrix-meow matrix-meow added this to the 1.2.0 milestone May 20, 2024
This was referenced May 20, 2024
Merged
Merged
Merged
@jensenojs
Copy link
Contributor

@XuPeng-SH 等cp到1.2-dev后徐鹏哥把它直接关掉就可以了吧

@jensenojs jensenojs assigned XuPeng-SH and unassigned matrix-meow May 21, 2024
@XuPeng-SH
Copy link
Contributor Author

@jensenojs 这个实际上是很多模块owner要做的，我那个pr是把几个明显的问题先解决掉

@XuPeng-SH XuPeng-SH assigned ouyuanning and unassigned XuPeng-SH May 22, 2024
@XuPeng-SH
Copy link
Contributor Author

@ouyuanning please investigate this problem in your modules

@ouyuanning
Copy link
Contributor

还没时间看

@sukki37 sukki37 modified the milestones: 1.2.0, 1.2.1 May 28, 2024
@ouyuanning
Copy link
Contributor

在处理w-w和prepare，还没时间处理

@ouyuanning
Copy link
Contributor

这周处理

@aressu1985 aressu1985 modified the milestones: 1.2.1, 1.3.0 Jun 7, 2024
@ouyuanning
Copy link
Contributor

还没时间清理

This was referenced Jun 11, 2024
Merged
Merged
@ouyuanning ouyuanning assigned XuPeng-SH and unassigned ouyuanning Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XuPeng-SH XuPeng-SH

Labels
kind/bug Something isn't working severity/s0 Extreme impact: Cause the application to break down and seriously affect the use
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
6 participants
@XuPeng-SH @ouyuanning @aressu1985 @jensenojs @sukki37 @matrix-meow