Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundryup overwrites foundry-zksync with base foundry #349

Open
PatrickAlphaC opened this issue Apr 26, 2024 · 1 comment
Open

foundryup overwrites foundry-zksync with base foundry #349

PatrickAlphaC opened this issue Apr 26, 2024 · 1 comment

Comments

@PatrickAlphaC
Copy link
Collaborator

Component

Forge

Describe the feature you would like

When I run foundryup to update my foundry edition, it removes my foundry-zksync installation.

Steps to reproduce:

  1. Install foundry-zksync (However you like)
  2. Run foundryup
  3. Try to do any foundry stuff with zksync, you cannot

Additional context

No response

@PatrickAlphaC PatrickAlphaC changed the title foundryup to update _this_ foundry foundryup overwrites foundry-zksync with base foundry Apr 26, 2024
@dutterbutter
Copy link
Collaborator

@PatrickAlphaC

Currently this is intentional as the installation uses the same base directory of .foundryup. If we want to avoid overwriting one another while also ensuring devs can execute the desired binary (between upstream and foundry-zksync) we would need to rename the binaries away from forge and cast. We want to keep the namespace the same, but perhaps we can introduce a forge version manager to switch between the two easily enough.

I will leave this open for now, but this is currently intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants