Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change to https link #363

Open
alexanderblv opened this issue May 6, 2024 · 2 comments · May be fixed by #376
Open

chore: change to https link #363

alexanderblv opened this issue May 6, 2024 · 2 comments · May be fixed by #376

Comments

@alexanderblv
Copy link

foundry-zksync/README.md

Line 71 in eda9078

git clone git@github.com:matter-labs/foundry-zksync.git

For public access, it is better to use an HTTPS link, as indicated in the official documentation
https://docs.zksync.io/build/
https://github.com/matter-labs/zksync-web-era-docs
@dutterbutter dutterbutter linked a pull request May 13, 2024 that will close this issue
Open
@Karrq
Copy link
Contributor

Karrq commented May 16, 2024

Actually, as per the official documentation instructs, an ssh link is more than fine

@alexanderblv
Copy link
Author

Actually, as per the official documentation instructs, an ssh link is more than fine

We are talking about public access. In this case, the HTTPS link looks preferable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update readme matter-labs/foundry-zksync
2 participants
@Karrq @alexanderblv