Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semversion instead of string for zksolc compiler #42

Open
berryhill opened this issue Apr 14, 2023 · 1 comment · May be fixed by #290
Open

Use semversion instead of string for zksolc compiler #42

berryhill opened this issue Apr 14, 2023 · 1 comment · May be fixed by #290
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@berryhill
Copy link

Info

Currently using a string for the zksolc-manager, we should refactor to use semversion
@berryhill berryhill self-assigned this Apr 24, 2023
@uF4No
Copy link
Collaborator

uF4No commented May 1, 2023

Related to this, we're publishing the latest and minimal zksolc versions to a JSON file available here.
In Hardhat we will add a validation in compilation time to make sure devs are using at least the minVersion and recommend using latest. If version is not specified, it should use the latest from the JSON file

@berryhill berryhill removed their assignment May 17, 2023
@mm-zk mm-zk added help wanted Extra attention is needed good first issue Good for newcomers labels May 30, 2023
@Velnbur Velnbur mentioned this issue Mar 9, 2024
Merged
@OmegaTymbJIep OmegaTymbJIep linked a pull request Mar 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Update zksolc_manager to auto fetch latest compiler OmegaTymbJIep/foundry-zksync
3 participants
@uF4No @berryhill @mm-zk