Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update zksolc_manager to auto fetch latest compiler #290

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

OmegaTymbJIep
Copy link

@OmegaTymbJIep OmegaTymbJIep commented Mar 24, 2024

What πŸ’»

  • Similar to hardhat-zksolc plugin we check for the latest zksolc and fetch if there is an updated version.
  • Use semver instead of string for zksolc version.

Why βœ‹

  • To remove hardcoded zksolc versioning which requires constant updating to retrieve the latest versions.

Evidence πŸ“·

image image image image

Notes πŸ“

@OmegaTymbJIep OmegaTymbJIep marked this pull request as draft March 24, 2024 18:21
@OmegaTymbJIep OmegaTymbJIep marked this pull request as ready for review April 2, 2024 09:21
@dutterbutter
Copy link
Collaborator

hey @OmegaTymbJIep really, really appreciate the contribution here! We are about to release our v2 version of Foundry from the dev branch which is very different structure to main. Any chance you can move these changes into the manager.rs file in the zksync crate on dev :)

@OmegaTymbJIep OmegaTymbJIep marked this pull request as draft April 10, 2024 07:22
@OmegaTymbJIep OmegaTymbJIep changed the base branch from main to dev May 6, 2024 09:25
@OmegaTymbJIep OmegaTymbJIep marked this pull request as ready for review May 6, 2024 11:20
@OmegaTymbJIep
Copy link
Author

@dutterbutter Hi! It is moved to the dev as a base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants