Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Reentrancy Vulnerability #1278

Open
mr-teikst opened this issue Feb 28, 2024 · 1 comment
Open

Potential Reentrancy Vulnerability #1278

mr-teikst opened this issue Feb 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mr-teikst
Copy link

馃悰 Bug Report

Potential Reentrancy Vulnerability

馃摑 Description

The validateAndPayForPaymasterTransaction function contains external calls to transfer tokens and pay fees. While these calls are currently protected by appropriate checks, there's a risk of reentrancy if the contract's state is not properly managed before and after external calls. Consider applying the "checks-effects-interactions" pattern or using the ReentrancyGuard modifier to prevent reentrancy attacks.
@mr-teikst mr-teikst added the bug Something isn't working label Feb 28, 2024
@EmilLuta
Copy link
Contributor

cc: @vladbochok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EmilLuta @mr-teikst