Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3_clientVersion of external-node does not return a meaningful value #1503

Open
pc-quiknode opened this issue Mar 27, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@pc-quiknode
Copy link

pc-quiknode commented Mar 27, 2024

馃悰 Bug Report

馃摑 Description

web3_clientVersion is expected to return the current client version of zkSync external node.
The value is currently hardcoded as zkSync/v2.0 at

馃攧 Reproduction Steps

Call JSON-RPC web3_clientVersion

{"jsonrpc":"2.0","id":1,"method":"web3_clientVersion","params":[]}

will emit a response of

{"jsonrpc":"2.0","result":"zkSync/v2.0","id":1}

馃 Expected Behavior

It should return the current client version

馃槸 Current Behavior

It always returns "zkSync/v2.0"

@pc-quiknode pc-quiknode added the bug Something isn't working label Mar 27, 2024
@EmilLuta
Copy link
Contributor

cc: @popzxc

@popzxc
Copy link
Member

popzxc commented Mar 28, 2024

@EmilLuta feel free to create an internal task to work on it, it indeed would be better to indicate the version of the client (though we need to discuss internally which versioning scheme do we want to use).

@EmilLuta
Copy link
Contributor

EmilLuta commented Mar 31, 2024

@pc-quiknode We've created an internal task for this, but it may take quite a while until it gets prioritized. External contributions are welcome as well (given our time-frame won't be enough). Thanks for raising the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants