Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With long instance names, the About message gets cut #26863

Open
mattermod opened this issue Apr 24, 2024 · 3 comments · May be fixed by #26955
Open

With long instance names, the About message gets cut #26863

mattermod opened this issue Apr 24, 2024 · 3 comments · May be fixed by #26955
Assignees
Labels
Help Wanted Community help wanted

Comments

@mattermod
Copy link
Contributor

In the product selector dropdown, there is the "About Mattermost" item.

If the instance name is anything different than Mattermost, it may grow beyond the menu space, cutting the string.

The string should use an ellipsis.

Issue created from a message in Mattermost.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-57900

@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels Apr 24, 2024
@Aryakoste
Copy link
Contributor

Hello @mattermod. I would like to work on this issue.

@Aryakoste
Copy link
Contributor

Hello @amyblais. The text and the icon is inside the MenuItem__primary-text class of menu_item_toggle_modal_redux. Which is of inline flex for proper alignment of icon and text. If i have to put text-overflow here i will have to make it display: block or inline-block but it will affect alignment. If i used another to surround the text only by something of div and class to give text-overflow but the text is formed by formatMessage method which is external node_module. What do you suggest i should do.

@larkox
Copy link
Contributor

larkox commented Apr 29, 2024

intl.formatMessage returns a string. <FormatMessage /> component should be fine to wrap. We are looking for the simplest solution, trying to avoid too many extra divs or complicated logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants