Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit false positive for mattermost-webapp #26968

Open
paragonie-security opened this issue May 7, 2024 · 0 comments
Open

npm audit false positive for mattermost-webapp #26968

paragonie-security opened this issue May 7, 2024 · 0 comments
Labels
Bug Report/Open Bug report/issue

Comments

@paragonie-security
Copy link

Summary

When first installing Mattermost, npm audit reports a critical issue for malware in a dependency, but appears to be a false positive.

Advisory link: GHSA-r5gc-r4qf-2vh7

Steps to reproduce

  1. Start a fresh install (from a git clone) of mattermost.
  2. cd webapp
  3. npm install && npm audit

Since mattermost-webapp is a channel name, the package from NPM is never directly installed.

Expected behavior

Just a report with lots of Regex DoS like usual for npm audit.

Observed behavior (that appears unintentional)

The audit report contains this segment:

mattermost-webapp  *
Severity: critical
Malware in mattermost-webapp - https://github.com/advisories/GHSA-r5gc-r4qf-2vh7
No fix available
channels
node_modules/mattermost-webapp

Possible fixes

In the PHP ecosystem, we have the ability to make a package that conflicts with every vulnerable version, thereby preventing it from ever being installed. I don't see a similar mechanism in package.json.

It may be possible to use overrides to achieve a similar effect, but it's not immediately clear to us if that will work. (We are not Node.js experts.)

@amyblais amyblais added the Bug Report/Open Bug report/issue label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report/Open Bug report/issue
Projects
None yet
Development

No branches or pull requests

2 participants