Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Animation builder doesn't work properly when total_frames is an input connected to INT type output #94

Open
ali1234 opened this issue Sep 8, 2023 · 3 comments
Assignees
Labels

Comments

@ali1234
Copy link

ali1234 commented Sep 8, 2023

Describe the bug

When animation builder's total_frames is set to an input and connected to a node which outputs an int, the total frames is always 100, and not the value that the node output. Note that this does not happen with primitive nodes.

Reproduction

  1. Add an animation builder.
  2. Connect frame output to MTB debug.
  3. Convert total_frames to an input.
  4. Add a math node like IntUnaryOperation and connect it to total frames.
  5. Click "queue" on animation builder.

Result: animation builder always thinks that there are 100 frames in total.

Expected behavior

Animation builder should queue the number of prompts output by the math node.

Operating System

Linux

Comfy Mode

In a custom virtual env (venv, virtualenv, conda...)

Console output

No response

Additional context

Example workflow:

workflow-anim-builder-bug

@ali1234 ali1234 added status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working labels Sep 8, 2023
@melMass melMass added status: 🧪 needs testing and removed status: 🧹 needs triage This issue needs to triage, applied to new issues labels Sep 13, 2023
@Bearoar
Copy link

Bearoar commented Sep 23, 2023

i got a problem with the animation builder, the node didn't show the Reset and Queue bottom, how can i solve this problem, uhhh,

@melMass
Copy link
Owner

melMass commented Sep 24, 2023

@Bearoar please open a dedicated issue it's not related.

@ali1234 This one that is probably due to a ComfyUI update but I haven't been able to dedicate time for it last week probably next week

@melMass melMass added this to the Release of v0.2.0 milestone Sep 25, 2023
@Immac
Copy link

Immac commented Jun 4, 2024

I can confirm this is still a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants