Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: meltano config <extractor> test fails for SDK-based taps configured to use BATCH messages #8525

Open
edgarrmondragon opened this issue May 2, 2024 · 0 comments

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented May 2, 2024

Meltano Version

3.4.0

Python Version

NA

Bug scope

CLI (options, error messages, logging, etc.)

Operating System

NA

Description

The meltano config <extractor> test command works under the assumption that the tap should output at least one RECORD message if it's correctly set up, but that was implemented before the SDK added support for BATCH messages.

The command should consider that either are valid.

Code

record_message_received = message_type == "RECORD"
if record_message_received:
process.terminate()
break

Related

@edgarrmondragon edgarrmondragon changed the title bug: meltano config <extractor> test fails for SDK-based taps configured to use BATCH messages bug: meltano config <extractor> test fails for SDK-based taps configured to use BATCH messages May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant