Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: websocket handler can only be declared in GET method when exposeHeadRoutes is used #457

Open
HosseinAgha opened this issue Apr 18, 2021 · 3 comments
Open

Error: websocket handler can only be declared in GET method when exposeHeadRoutes is used #457

HosseinAgha opened this issue Apr 18, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@HosseinAgha
Copy link

HosseinAgha commented Apr 18, 2021 •
edited

When exposeHeadRoutes is true in fastify factory function options, I get the Error: websocket handler can only be declared in GET method. I think this error is from Mercurius as I don't use WebSocket plugin.
As this option is enabled by default in fastify (fastify/fastify#2826), I think we need to resolve this issue as fast as possible.
@mcollina
Copy link
Collaborator

This option is not enabled by default. It will be enabled in the next major release.

@mcollina
Copy link
Collaborator

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@HosseinAgha
Copy link
Author

Thank you,
I'd be happy to. But I'm so busy at the moment.
I'll try to open a PR as soon as I could.

@mcollina mcollina added the bug Something isn't working label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @HosseinAgha