Cover Offset() in aggregations with e2e tests
#42455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it wasn't possible to import the utils file in e2e tests without it
kamilmielnik
commented
May 13, 2024
| @@ -0,0 +1,29 @@ | |||
| export function uuid() { | |||
There was a problem hiding this comment.
I moved uuid to a separate file because I wanted to import it in e2e tests, but importing metabase/lib/utils.ts file in e2e tests caused a webpack error due to some non-importable asset being referenced in metabase/plugins.
I also renamed isUUID to isUuid and made it into a type guard (: uuid is string).
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f847425...6631cdd.
|
|
uladzimirdev
approved these changes
May 13, 2024
| createQuestion({ query }, { visitQuestion: true }); | ||
|
|
||
| verifyNoQuestionError(); | ||
| /* TODO: assert actual values */ |
There was a problem hiding this comment.
are you going to merge it like this? or is it a leftover?
There was a problem hiding this comment.
Merge like this for now.
This test is a repro for not-yet-fixed bug and is skipped for now.
I added info about updating the assertion in the relevant issue: #42554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42452
Description
e2e tests for the
Offset()function - only in custom aggregation expressions for now.Custom columns and custom filter expressions are not going into v50 (see Slack).
Issues found because of this PR:
Offset()#42554