Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerized unit tests #2200

Open
2 tasks done
fedepaol opened this issue Dec 6, 2023 · 3 comments
Open
2 tasks done

Containerized unit tests #2200

fedepaol opened this issue Dec 6, 2023 · 3 comments

Comments

@fedepaol
Copy link
Member

fedepaol commented Dec 6, 2023

Is your feature request related to a problem?

This was raised in slack, where the speaker does not build because of

# go.universe.tf/metallb/internal/bgp/native
internal/bgp/native/native.go:564:38: undefined: unix.SOCK_CLOEXEC
internal/bgp/native/native.go:564:58: undefined: unix.SOCK_NONBLOCK
internal/bgp/native/native.go:588:50: undefined: unix.SetsockoptTCPMD5Sig

According to golang/go#30539 (comment) , there are simply primitives that are not available in macos.

Describe the solution you'd like

Having a way to run unit tests inside containers (possibly via inv), so developers using mac can run unit tests.
This might be challenging because of the dockertest frr semi-integration tests.

Additional context

No response

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.
@7h3-3mp7y-m4n
Copy link

can i work on this? , and can you assist me too when I'll face some issues while fixing this

@fedepaol
Copy link
Member Author

Sure thing, and of course we'll help you!

@7h3-3mp7y-m4n
Copy link

thanks @fedepaol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants