Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running inv dev-env fails with GOBIN set #2218

Open
8 tasks done
andreaskaris opened this issue Dec 18, 2023 · 0 comments
Open
8 tasks done

Running inv dev-env fails with GOBIN set #2218

andreaskaris opened this issue Dec 18, 2023 · 0 comments
Labels

Comments

@andreaskaris
Copy link
Contributor

andreaskaris commented Dec 18, 2023

MetalLB Version

all

Deployment method

Not relevant

Main CNI

not relevant

Kubernetes Version

not relevant

Cluster Distribution

not relevant

Describe the bug

Running inv dev-env fails with GOBIN set

$ env | grep GOBIN
GOBIN=/home/akaris/development/go/bin
inv dev-env -n ovn -b frr -p bgp
(...)
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
/bin/bash: line 1: /home/akaris/development/metallb/build/bin/controller-gen: No such file or directory

To Reproduce

Running inv dev-env fails with GOBIN set

$ env | grep GOBIN
GOBIN=/home/akaris/development/go/bin
inv dev-env -n ovn -b frr -p bgp
(...)
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
/bin/bash: line 1: /home/akaris/development/metallb/build/bin/controller-gen: No such file or directory

Expected Behavior

Should not fail

Additional Context

Running inv dev-env fails with GOBIN set

$ env | grep GOBIN
GOBIN=/home/akaris/development/go/bin
inv dev-env -n ovn -b frr -p bgp
(...)
go: downloading github.com/modern-go/reflect2 v1.0.2
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
/bin/bash: line 1: /home/akaris/development/metallb/build/bin/controller-gen: No such file or directory

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.

I've read and agree with the following

  • I've checked all open and closed issues and my issue is not there.
  • This bug is reproducible when deploying MetalLB from the main branch
  • I have read the troubleshooting guide and I am still not able to make it work
  • I checked the logs and MetalLB is not discarding the configuration as not valid
  • I enabled the debug logs, collected the information required from the cluster using the collect script and will attach them to the issue
  • I will provide the definition of my service and the related endpoint slices and attach them to this issue
andreaskaris added a commit to andreaskaris/metallb that referenced this issue Dec 18, 2023
When GOBIN is already set, go install will install the binary to that
path. However,  line 'run("{}/bin/controller-gen...' expects
controller-gen to be installed under build/bin/controller-gen. Force
GOBIN to the correct value, always.

Reported-at: metallb#2218
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
andreaskaris added a commit to andreaskaris/metallb that referenced this issue Dec 18, 2023
When GOBIN is already set, go install will install the binary to that
path. However,  line 'run("{}/bin/controller-gen...' expects
controller-gen to be installed under build/bin/controller-gen. Force
GOBIN to the correct value, always.

Reported-at: metallb#2218
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
andreaskaris added a commit to andreaskaris/metallb that referenced this issue Jan 8, 2024
When GOBIN is already set, go install will install the binary to that
path. However,  line 'run("{}/bin/controller-gen...' expects
controller-gen to be installed under build/bin/controller-gen. Force
GOBIN to the correct value, always.

Reported-at: metallb#2218
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
github-merge-queue bot pushed a commit that referenced this issue Jan 11, 2024
When GOBIN is already set, go install will install the binary to that
path. However,  line 'run("{}/bin/controller-gen...' expects
controller-gen to be installed under build/bin/controller-gen. Force
GOBIN to the correct value, always.

Reported-at: #2218
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
fedepaol pushed a commit to fedepaol/metallb that referenced this issue Jan 30, 2024
When GOBIN is already set, go install will install the binary to that
path. However,  line 'run("{}/bin/controller-gen...' expects
controller-gen to be installed under build/bin/controller-gen. Force
GOBIN to the correct value, always.

Reported-at: metallb#2218
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant