Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watermark documents #288

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ashrafchowdury
Copy link
Contributor

Description

Implemented a feature watermark documents. Users can toggle the watermark on or off and move it around the document as needed.
The watermark is placed at the bottom right of the document and can be moveable, showing the viewer's email and viewing time.

Feature

  • Watermark documents.
  • Watermark is moveable within the document.

Preview

Untitled.video.-.Made.with.Clipchamp.mp4

Issue

Closes #267

Copy link

vercel bot commented Feb 17, 2024

@ashrafchowdury is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

@mfts
Copy link
Owner

mfts commented Feb 26, 2024

I like this but I think the watermark should not be movable. instead it should be permanently attached to the image in a fixed location.

Not sure how to best make this happen quite yet but maybe you find a way :)

@ashrafchowdury
Copy link
Contributor Author

Hey @mfts, can you confirm if the pro version includes the watermark feature? What will be the default behaviour (open or close) if it's not included in the pro version? That way, I can make changes accordingly.

@mfts
Copy link
Owner

mfts commented Feb 29, 2024

@ashrafchowdury this would most definitely be a pro feature.

it would be awesome if we could manipulate the image before it hits the client. so far I only know of a solution that involves S3 lambda.

@ashrafchowdury
Copy link
Contributor Author

ashrafchowdury commented Feb 29, 2024

@ashrafchowdury this would most definitely be a pro feature.

it would be awesome if we could manipulate the image before it hits the client. so far I only know of a solution that involves S3 lambda.

If we manipulate the image most probably the watermark will fall into the empty space of the image.

It would be beneficial for us if we could display raw PDFs to the client instead of images to unlock new feature possibilities. What do you think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] add watermarking to documents
2 participants