Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can add a share feature to the link that is created. #16

Open
aryan-139 opened this issue Jun 11, 2023 · 9 comments · May be fixed by #276
Open

Can add a share feature to the link that is created. #16

aryan-139 opened this issue Jun 11, 2023 · 9 comments · May be fixed by #276

Comments

@aryan-139
Copy link

I have been going through Papermark and right after creating the link. It might be good if we give options to share the link directly embedded as a Tweet.

We can start with a Tweet first, then expand the sharing horizons as the need arises.

I can work on this!

@mfts
Copy link
Owner

mfts commented Jun 11, 2023

That is a great idea. A share interface would be really actionable.

I'm pushing a PR today that enhances the upload/link creation and based on that it would be great to add a share function.

@saidinusah
Copy link

Hello, please confirm if this is done. I'd like to contribute

@mfts
Copy link
Owner

mfts commented Sep 4, 2023

@1nusah this is not implemented yet. Feel free to contribute that feature :)

@surya-nand
Copy link

Hey Mark, I would like to contribute

@mfts
Copy link
Owner

mfts commented Sep 9, 2023

@surya-nand Yes absolutely. I will release a roadmap this weekend and we get can started contributing together. If you already have something in mind let me know.

@surya-nand
Copy link

Along with an embedding link to share it as a tweet or text. I feel the link should look more credible, receivers should know what they are going to open.

https://papermark.io/view/${userName}/${documentName}${uniqueID}( This will look more credible than below )
https://papermark.io/view/clmbv79gp0002mj08o394lgcq

What do you think Mark?

@saidinusah
Copy link

This makes sense especially on the credibility bit

@mfts
Copy link
Owner

mfts commented Sep 10, 2023

https://papermark.io/view/${userName}/${documentName}${uniqueID}

This is a good suggestion. It would elongate the link a lot by a lot. Instead we should shorten it by introducing custom slugs like

  • https://papermark.io/view/${uniqueSlug}
  • https://papermark.io/${uniqueSlug}

So that we have either a random slug like "/cdhhdkeonq123jdk" or a personalized one like "/presentation"

This is already possible for custom domains. Shouldn't be too difficult to port that over.

@surya-nand
Copy link

As you said earlier, drop your roadmap this week
We can contribute together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants