Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Link Appears on Post Page Despite Admin Disablement #102

Open
yeldarx opened this issue Oct 8, 2023 · 2 comments
Open

JSON Link Appears on Post Page Despite Admin Disablement #102

yeldarx opened this issue Oct 8, 2023 · 2 comments

Comments

@yeldarx
Copy link

yeldarx commented Oct 8, 2023

Hello!

I disabled JSON in admin panel, but its link is published on the post page. If you click on the json link the error Not found appears, which is correct, because the function is disabled. The bug is that the JSON link should not be published on the post page after it is disabled.

Screen Shot 2023-10-08 at 22 12 01
Screen Shot 2023-10-08 at 22 12 32

@wenbinf
Copy link
Member

wenbinf commented Oct 8, 2023

That's actually working as expected -

  1. After you turned JSON to invisible, the json link returns 404 - you can click on the link to verify.

  2. The "json" link on the post page is just part of the html template, which can be modified at /admin/settings/code-editor/?type=themes&theme=custom#webItem

@wenbinf
Copy link
Member

wenbinf commented Oct 8, 2023

TODO: make the html template smart enough to hide such rss / json links if rss/json become invisible.

This could be a good pull request from external code contributors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants