Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting item entry doesn't delete file #91

Open
postite opened this issue Aug 11, 2023 · 2 comments
Open

deleting item entry doesn't delete file #91

postite opened this issue Aug 11, 2023 · 2 comments

Comments

@postite
Copy link

postite commented Aug 11, 2023

not sure if it is a bug or a feature request :|

@wenbinf
Copy link
Member

wenbinf commented Aug 11, 2023

The intentional design currently accommodates specific edge cases concerning the auto-deletion of R2 files. For instance, if an image is embedded across multiple websites and is inadvertently overlooked, deleting the image (as a result of removing an associated item) will lead to broken links, resulting in 404 errors.

Retaining files on R2, S3, or other storage engines is generally not a concern in today's context, given the abundance of storage space and typically small file sizes. While a large accumulation of such undeleted files could potentially become an issue, engineering often requires making trade-offs. It is acceptable to intentionally leave certain imperfections unaddressed, prioritizing time for more urgent or important matters, and maintaining an overall simple implementation, which facilitates straightforward troubleshooting.

In the future, we plan to develop a separate media manager that will allow for the direct deletion or movement of files on R2:
#39

@kenara
Copy link

kenara commented Sep 5, 2023

@wenbinf, your remark about trade-offs is insightful. Still, I can think about a couple of use cases for deletion. One is the need to respond to take-down requests that may have legal consequences. Another would be for uploads whose item is never completed (Create button never pressed but potentially large object never seen by anyone).

It's hard to find an object to delete from the Cloudflare R2 objects dashboard, as the objects are listed alphabetically and Microfeed objects receive random-ish ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants