Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd: switch from git submodule to system installed library and cmake FetchContent #311

Open
pabs3 opened this issue Jun 21, 2022 · 0 comments
Open

zstd: switch from git submodule to system installed library and cmake FetchContent #311

pabs3 opened this issue Jun 21, 2022 · 0 comments

Comments

@pabs3
Copy link

pabs3 commented Jun 21, 2022

People building SPTAG packages on Linux distributions will want to use the system installed zstd library. People building SPTAG in other situations will want to use the latest release of zstd. Using a git submodule means that builders are always locked into the version of zstd that you have chosen. If you switch to a system where you use system build dependencies or cmake FetchContent, then builders will be able to use the version of zstd that they choose.
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 21, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
e93c316 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 21, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
8980727 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 26, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
d95f8d3 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 26, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
7e4fa14 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 26, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
76c62f0 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 29, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
9e6cfae 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jul 12, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
e304f44 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jul 18, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
bd09529 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jul 26, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
555e7a8 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Nov 13, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
f21ba83 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Nov 13, 2022
@pabs3
Switch from git submodule to system library for zstd dependency
bffae3b 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Feb 5, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
3f8419f 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Feb 6, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
a5b56b8 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
c7c0bfd 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
87cdb42 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 25, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
205bbc3 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Mar 25, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
09408da 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
2b33bcd 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
156684b 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
703eefb 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
a8680c8 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
f4c6f20 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
0807a2c 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
fd134fd 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
3191ecc 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Apr 1, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
9c7bc2c 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue May 3, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
7772b7b 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue May 10, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
0ef86fc 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jun 16, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
a02c38c 
Fixes: microsoft#311
pabs3 added a commit to pabs3/SPTAG that referenced this issue Jul 20, 2023
@pabs3
Switch from git submodule to system library for zstd dependency
a7504a9 
Fixes: microsoft#311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pabs3