Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename symbol weirdness with typescript type properties #58479

Open
greentore opened this issue May 8, 2024 · 0 comments
Open

Rename symbol weirdness with typescript type properties #58479

greentore opened this issue May 8, 2024 · 0 comments

Comments

@greentore
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.89.0
  • OS Version: Windows 10

Steps to Reproduce:

Case A (working)

// caseA.ts
type a = {
  A: 0;
};

type b = a["A"];
  1. Click on A (in a["A"]), press F2 and rename to f
  2. A is renamed in both places

Case B (broken)

// a.ts
export type a = {
  A: 0;
};
// caseB.ts
import { a } from "./a.ts";

type b = a["A"];
  1. Click on A (in a["A"]), press F2 and rename to f
  2. A is renamed in a.ts, but not in caseB.ts

Case C (working)

// caseC.ts
import { a } from "./a.ts";

type b = a["A"];

type A = "whatever";
  1. Click on A (in a["A"]), press F2 and rename to f
  2. A is renamed in both places
@mjbvz mjbvz transferred this issue from microsoft/vscode May 8, 2024
@mjbvz mjbvz removed their assignment May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants