Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Key Vault Secrets after initial create #330

Open
3 tasks
ianphil opened this issue Sep 26, 2019 · 0 comments
Open
3 tasks

Ignore Key Vault Secrets after initial create #330

ianphil opened this issue Sep 26, 2019 · 0 comments
Assignees
Labels
bug Something isn't working effort - large 3 day effort epic A larger set of functionality that encompasses multiple Stories pri-Med Medium priority issue spike investigate technical design approach; disambiguate

Comments

@ianphil
Copy link
Contributor

ianphil commented Sep 26, 2019

Description

As an engineer, I'd like to ensure that the secrets in key vault can change from outside of TF and not have TF recreate them, in order to allow for key rotation.

We should add the ignore lifecycle [or something similar] to these items and possibly the AD SP/App Registration items. We probably will need to look deeper into this and how the two interact.

Examples:

Thoughts:

  • This should create these secrets on first run.
  • All subsequent runs it should ignore them as they are always used and could be changed by an organizations key/secret rotation strategy.
  • App registration will probably need to be treated similarly. And another set of stories should be created if that is the case.

Acceptance Criteria

Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

  • Should only ever create the secrets once
  • Should not affect the AD App Registrations lifecycle
  • Should not affect the AD Service Principle lifecycle

Also, here are a few points that need to be addressed:

  1. Constraint 1;
  2. Constraint 2;
  3. Constraint 3.

Resources

Technical Design Document
Mockups

Tasks

Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic.
Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)

Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)

Assignee should break down work into tasks here

@ianphil ianphil added bug Something isn't working effort - large 3 day effort pri-Med Medium priority issue labels Sep 26, 2019
@ianphil ianphil added this to Sprint Backlog in Current Iteration via automation Sep 26, 2019
@ianphil ianphil added spike investigate technical design approach; disambiguate epic A larger set of functionality that encompasses multiple Stories labels Sep 26, 2019
@ianphil ianphil moved this from Sprint Backlog to V1 in Current Iteration Sep 30, 2019
@erikschlegel erikschlegel moved this from V1 to Active in Current Iteration Sep 30, 2019
@erikschlegel erikschlegel moved this from Active to PR Submitted in Current Iteration Oct 3, 2019
@erikschlegel erikschlegel moved this from PR Submitted to Done in Current Iteration Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort - large 3 day effort epic A larger set of functionality that encompasses multiple Stories pri-Med Medium priority issue spike investigate technical design approach; disambiguate
Projects
Development

No branches or pull requests

2 participants