Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFNavigationBar does not update the title on the same instance unless titleView is reset. #1968

Open
1 task
ychung25 opened this issue Feb 11, 2024 · 0 comments

Comments

@ychung25
Copy link

ychung25 commented Feb 11, 2024

MSFNavigationBar does not update the title on the same instance unless titleView is reset.
NavigationBar.Swift :: updateSubtitleView, it checks for navigationItem.titleView == nil and returns without setting navigationItem.titleView = customTitleView.

So without setting viewController.navigationItem.titleView to nil, the following code will not update the navbar title on the same instance of viewController if it was run once before.

viewController.title = "My Custom Title"
navigationController?.pushViewController(viewController, animated: true)

Please look into fixing this. If this is there for a reason for this behaviuor, please expose an API that allows to set navbar title without having set viewController.navigationItem.titleView = nil

Environment Information

  • Platform:
    • [ x] iOS
    • macOS

Please provide a reproduction of the bug:

Explained above.

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)
No

Requested priority: (Blocking, High, Normal, Low)
Low

Products/applications affected: (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant