You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There isn't any prop that would allow identify TagItem component. It is problematic for e2e testing and tracking user interactions when you need to keep track of clicks on tag items, for example, within TagPicker component.
My proposition is to allow at least data-id attribute in ITagItemProps. Alternatively, any data-* as in HTML.
These data-* props would be propagated to IconButton.
I have a related issue with TagItemSuggestion. it supports data-* attributes, but it is a clickable div. Unfortunately, App Insights does not track clicks on div elements. If we change TagItemSuggestion from div to button, it should not break anything, it will be semantically correct and it will improve interoperability between FluentUi-App Insights.
Library
React / v8 (@fluentui/react)
Describe the feature that you would like added
There isn't any prop that would allow identify
TagItem
component. It is problematic for e2e testing and tracking user interactions when you need to keep track of clicks on tag items, for example, withinTagPicker
component.My proposition is to allow at least
data-id
attribute in ITagItemProps. Alternatively, anydata-*
as in HTML.These
data-*
props would be propagated to IconButton.Proposed interface would allow:
In combination with
TagPicker
Which would generate following HTML:
If this makes sense to you, I'm willing to send the PR.
Have you discussed this feature with our team
Yes, internally
Additional context
No response
Validations
Priority
Normal
The text was updated successfully, but these errors were encountered: