-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup when someone marks something #5031
Comments
That popup does not appear to be coming from Live Share. |
Like the guy mentioned in #5032 I am also working on a vue/ TypeScript project. Relevant Extensions for this project are probably the following: JavaScript and TypeScript Nightly Maybe you can figure something out. Im going to start to disable all extensions, so i might be able to find the one relating this issue. |
Our team is also experiencing this on a vue/TypeScript project, though it doesn't seem to be limited to when both people are typing. It is only occurring on the host's IDE, and only while in Read/Write mode, not in ReadOnly mode. It is making LiveShare unworkable. Extensions: |
The extension in common is "Vue Official" extension. Hopefully that resolves your issue but it doesn't seem to be caused by Live Share. |
When the user selects HTML code in the SFC template and executes the Does one client executing https://github.com/search?q=repo%3Avuejs%2Flanguage-tools%20refactor.move.newFile.dumb&type=code |
@johnsoncodehk it seems that something else is triggering this behaviour. Here is my reproduction:
I do not need to do anything else like selecting any code or executing a command so there is something else that is triggering this refactor. In non-vue file the IntelliSense popup appears and stays, while in vue files it is quickly closed and the popup appears. |
Reverting the Vue - Official extension to v1.8.27 resolved the issue for our team. |
Thank you for your explanation. As far as I know, step 5 is incorrect. It should be triggered when selecting a piece of code in the I have thought of two ways to solve this problem.
|
@johnsoncodehk I see that none of those options is possible in near future so I appreciate that you've added While I see much bigger value in pair/mob programming than in easy component extraction I hope that at some point VSCode/Live Share team will provide a solution that is not limiting capabilities for Vue ecosystem and will let you implement the proper solution for this issue. I wish you all the best :) |
Product and Version [VS/VSCode]: Most recent
OS Version[macOS/Windows]: macOS Sonoma 14.4
Live Share Extension Version: v1.0.5905
Steps to Reproduce / Scenario:
Please attach logs to this issue:
logs.zip
Screenshots
The text was updated successfully, but these errors were encountered: