-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crashpad] Update to latest version 2024-05-10 #38703
Conversation
// Work around libstdc++ bug 51038 where atomic_thread_fence was declared but | ||
// not defined, leading to the linker complaining about undefined references. | ||
- __atomic_thread_fence(std::memory_order_seq_cst); | ||
+ __atomic_thread_fence(static_cast<int>(std::memory_order_seq_cst)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an upstream patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you submit this patch upstream?
Fixes #38702
SHA512s are updated for each updated download.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.