Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug context menu contribution points #200880

Open
thegecko opened this issue Dec 14, 2023 · 7 comments · May be fixed by #212501 or #212499
Open

Debug context menu contribution points #200880

thegecko opened this issue Dec 14, 2023 · 7 comments · May be fixed by #212501 or #212499
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@thegecko
Copy link
Contributor

Apologies if this is too similar to existing requests, but I'm keen to pull together a common request for adding debug contribution points.

Similar requests:

And related:

Rationale:

Debugging often needs deep integration between views (e.g. embedded debugging) where they are all driven from a common context and can interact with other. A common way to add these links/commands is through contribution points and some of the provided debug views lack these extension points. Can I suggest contribution points in context menus for the following:

  • Watch view (e.g. to open the value in a memory viewer)
  • Breakpoints view (e.g. to expose a 'run to breakpoint' command)
  • Disassembly view (e.g. to show source, manage breakpoints, show memory)
  • Debug viewlet bar (e.g. to add a command to launch a custom GUI to create a complex debug configuration)

I assume this is the debug viewlet:

Screenshot 2023-12-14 at 19 03 34

Happy to work on a PR if this is of interest.

@roblourens
Copy link
Member

I am open to these for areas where the data type in the list is represented in the extension API already (eg Breakpoints). For others, like variables, that would involve having to think about how that type should look presented to an extension, which would take more effort.

@roblourens roblourens added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Dec 14, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Dec 14, 2023
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@roblourens
Copy link
Member

I guess we actually have this for variables already

@thegecko
Copy link
Contributor Author

I guess we actually have this for variables already

We do, the ask is to consider this for some of the other views

@VSCodeTriageBot
Copy link
Collaborator

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@theIDinside
Copy link

theIDinside commented Jan 16, 2024

I am open to these for areas where the data type in the list is represented in the extension API already (eg Breakpoints). For others, like variables, that would involve having to think about how that type should look presented to an extension, which would take more effort.

I definitely understand the difficulty or that this isn't a trivial feature. But at the same time, when it comes to the debug adapter interface, we have a clear spec to adhere to. That's the API - and in a sense, no more, no less (though I'm sure there's always a bunch of new cool magical stuff one can add).

I think it would be neat if VSCode therefore exposed this functionality in a "bi-directional" fashion (sort of) as it's already well defined in the DAP spec. The debug adapter knows what data it gives VSCode, the DAP spec is clear on life times and object references and therefore it should not be that troublesome to pass that data back and forth - even outside of a normal "debug adapter request chain"; since the spec is clear that, for instance, variablesReference: 1 is only valid until the next resume request.

I don't know if this rant made any sense, but it's an attempt to spark a discussion in hopes of possibly moving something forward.

@thegecko
Copy link
Contributor Author

Proposed contribution points covering this request can now be found in these PRs:

cc @roblourens @isidorn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
4 participants