Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: monaco diff revert buttons #212771

Closed
nanaSun opened this issue May 15, 2024 · 0 comments · Fixed by #213584 · May be fixed by #212772
Closed

Bug: monaco diff revert buttons #212771

nanaSun opened this issue May 15, 2024 · 0 comments · Fixed by #213584 · May be fixed by #212772
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
May 2024

Comments

@nanaSun
Copy link

nanaSun commented May 15, 2024 •
edited by hediet

Verification steps:

  • Open playground
  • Click on the first diff
  • Notice that the arrow is at the wrong location
    chrome_Yma54b8nbM
  • Verify that this is fixed in the latest nightly monaco editor release

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code : Monaco @ 0.48.0

Steps to Reproduce:

  1. Diff Editor with gutter item's position
截屏2024-05-15 14 41 22
@nanaSun nanaSun mentioned this issue May 15, 2024
Open
@alexdima alexdima assigned hediet and unassigned alexdima May 27, 2024
@hediet hediet added this to the May 2024 milestone May 27, 2024
hediet added a commit that referenced this issue May 27, 2024
@hediet
Fixes #212771
c7b1d77
@hediet hediet mentioned this issue May 27, 2024
Merged
@hediet hediet added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues labels May 27, 2024
hediet added a commit that referenced this issue May 27, 2024
@hediet
Fixes #212771 (#213584)
957f18b
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 27, 2024
@sandy081 sandy081 added the verified Verification succeeded label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Fixes #212771 microsoft/vscode
fix: monaco diff revert style nanaSun/vscode
5 participants
@hediet @alexdima @sandy081 @nanaSun @VSCodeTriageBot