Inline chat widget: show / hide issues

[bpasero]

Background

In inline chat, there are 2 chat widgets, the one showing initially ("lightweight") and the other when a response comes ("heavy"):

Lightweight:

Heavy:

In both widgets, a 🎤 action is provided to start voice chat. When you click it, the icon animates and on macOS you see the yellow indicator in the up-right corner:

In addition, with text-to-speech integration, responses can be read aloud, which is indicated by another animation:

In the code that deals with starting speech-to-text and text-to-speech sessions, I want to make sure to stop the session when chat hides. For that I rely on ChatWidget.setVisible() calls here:

vscode/src/vs/workbench/contrib/chat/browser/chatWidget.ts

Line 393 in f9a2d55

setVisible(visible: boolean): void {

Issue

In my testing, I do not see a call to ChatWidget.setVisible() when I close the "heavy" inline chat box, while it works fine for the lightweight one.

To reproduce:

• add a breakpoint to inlineChatContentWidget.hide()
• bring up inline chat in an editor
• close the "lightweight" one and notice how hide is called and proceeds to this._widget.setVisible(false);
• bring it up again and ask a question to get "heavy" inline chat
• click the "X" button to close it
• 🐛 hide is called, but immediately returns because this._visible is false

I wonder if for the transition from "lightweight" to "heavy", a call to show is missing?