Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test error report is off by 1 lines #212808

Closed
bpasero opened this issue May 15, 2024 · 0 comments · Fixed by #213081
Closed

Test error report is off by 1 lines #212808

bpasero opened this issue May 15, 2024 · 0 comments · Fixed by #213081
Assignees
@connor4312
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
May 2024

Comments

@bpasero
Copy link
Member

bpasero commented May 15, 2024

In insiders with selfhost test runner, assertion fails are off for me:

image
connor4312 added a commit that referenced this issue May 20, 2024
@connor4312
eng: fix off-by-1 error in selfhost test error messages
afdbad1 
Fixes #212808
@connor4312 connor4312 mentioned this issue May 20, 2024
Merged
connor4312 added a commit that referenced this issue May 20, 2024
@connor4312
eng: fix off-by-1 error in selfhost test error messages (#213081)
7828baa 
Fixes #212808
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 20, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 20, 2024
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue May 22, 2024
@connor4312 @mustard-mh
eng: fix off-by-1 error in selfhost test error messages (microsoft#21…
cad86b0 
…3081)

Fixes microsoft#212808
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 24, 2024
andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this issue May 26, 2024
@connor4312 @andremmsilva
eng: fix off-by-1 error in selfhost test error messages (microsoft#21…
db3034c 
…3081)

Fixes microsoft#212808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

eng: fix off-by-1 error in selfhost test error messages microsoft/vscode
3 participants
@bpasero @connor4312 @VSCodeTriageBot