Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dark Mode #1969

Open
4 tasks done
userzzzq opened this issue Apr 18, 2024 · 5 comments
Open
4 tasks done

Improve Dark Mode #1969

userzzzq opened this issue Apr 18, 2024 · 5 comments

Comments

@userzzzq
Copy link

userzzzq commented Apr 18, 2024

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Description

some UI still use white background, such as the Merge Files page, the scrollbar of "batch files" pannel (at left).
please improve the dark mode.

@mifi
Copy link
Owner

mifi commented Apr 18, 2024

related #733

@zzaria
Copy link

zzaria commented Apr 22, 2024

also an option to use the system theme

@Igetin
Copy link

Igetin commented Apr 26, 2024

also an option to use the system theme

Yeah, I would appreciate an option to synchronize the UI to the system theme. For reference, Electron's native-theme API should work fine for this and supports Linux/Windows/macOS.

@XCanG
Copy link

XCanG commented May 14, 2024

@mifi I have a little suggestion: add style color-scheme

You can use color-scheme: light dark; to support both themes, even right now it would improve scroll bars, an example if you add this to html element styles via devtools:

  • Default styles:
    2024-05-14_19-30-24_LosslessCut
  • With color-scheme and dark system theme:
    2024-05-14_19-30-51

Another screen example:

  • Default:
    2024-05-14_19-31-15_LosslessCut
  • With:
    2024-05-14_19-31-41_LosslessCut

Additionally there is light-dark() function that will allow you to style freely between both themes, like that:

.selector {
    background-color: light-dark(var(--light-background), var(--dark-background));
    color: light-dark(var(--light-text), var(--dark-text));
}

Currently lossless-cut use Chrome version 118, so it is not supported.
image

But if you upgrade Electron with a Chrome version 123 or newer, you can easily use it.

@XCanG
Copy link

XCanG commented May 14, 2024

Well, it is also possible to manually restyle scrollbars with CSS instead of relying on color-scheme like that (Chrome-only):

*::-webkit-scrollbar {
	width: 8px;
	height: 8px;
	background-color: transparent;
}

*::-webkit-scrollbar-thumb {
	background-color: #8888;
}

*::-webkit-scrollbar:hover {
	background-color: #8883;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants