Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom folder paths for exports on Windows #1979

Open
4 tasks done
t3dotgg opened this issue May 1, 2024 · 1 comment
Open
4 tasks done

Custom folder paths for exports on Windows #1979

t3dotgg opened this issue May 1, 2024 · 1 comment

Comments

@t3dotgg
Copy link
Sponsor

t3dotgg commented May 1, 2024

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Description

I cut an issue about bad folder directories being created on Windows awhile ago #1790

Just set up a new PC and updated to latest Lossless-Cut. Didn't realize I wouldn't be able to export to per-segment directories anymore :(

Ideally I'd still be able to use (dynamic) folder names on Windows. If not, I think a better error here would be nice.

Also thought that turning off sanitization should let me do this still :(

image
@mifi
Copy link
Owner

mifi commented May 3, 2024

Hmm, I just tested on windows 11 and I'm not getting this error on 3.59.1 when including a slash, and it's correctly creating the clips directory for me.

What I'm suspecting is that one of your segments' SEG_LABEL variable contains disallowed characters. If you click on Preview button, what do you see as "resulting file names"? on windows, when sanitize is "off", the following characters are not allowed: '<', '>', ':', '"', '|', '?', '*'

['<', '>', ':', '"', '|', '?', '*'].forEach((char) => invalidChars.add(char));

I think a better error here would be nice.

I will improve the error message to specify exactly which characters are invalid.

mifi added a commit that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants