Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: The query node fails to exit normally during rolling upgrades #32901

Closed
1 task done
zhuwenxing opened this issue May 9, 2024 · 8 comments
Closed
1 task done

[Bug]: The query node fails to exit normally during rolling upgrades #32901

zhuwenxing opened this issue May 9, 2024 · 8 comments
Assignees
@zhuwenxing @weiliu1031
Labels
kind/bug Issues or changes related a bug priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
2.4.2

Comments

@zhuwenxing
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.3-20240508-89e6b6ae-amd64）--> 2.4-20240508-19f09206-amd64 
- Deployment mode(standalone or cluster):mixcoord and cluster
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

image

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

failed job: https://qa-jenkins.milvus.io/blue/organizations/jenkins/rolling_update_for_operator_test_simple/detail/rolling_update_for_operator_test_simple/3359/pipeline

log:
artifacts-kafka-mixcoord-3359-server-logs.tar.gz

Anything else?

No response
@zhuwenxing zhuwenxing added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2024
@zhuwenxing zhuwenxing added this to the 2.4.2 milestone May 9, 2024
@zhuwenxing zhuwenxing added the severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. label May 9, 2024
@zhuwenxing
Copy link
Contributor Author

/assign @weiliu1031

@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 10, 2024
@yanliang567 yanliang567 removed their assignment May 10, 2024
@yanliang567 yanliang567 added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label May 10, 2024
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue May 10, 2024
@weiliu1031
fix: Segment on stopping query node can't be release successfully
a8082f7 
issue: milvus-io#32901
Cause release segment request need be send to delegator, but it need replica
to info find segment's delegator. but the stopping query node will be
marked as read only in replica, then `replica.Contains()` just return true
for rwNode in replica. then it can't get replica info by stopping query
node and release segment will be blocked.

This PR make `replica.Contains()` return true for both roNode and
rwNode.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 mentioned this issue May 10, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 10, 2024
@weiliu1031
fix: Segment on stopping query node can't be release successfully (#3…
04a8ec6 
…2929)

issue: #32901
Cause release segment request need be send to delegator, but it need
replica to info find segment's delegator. but the stopping query node
will be marked as read only in replica, then `replica.Contains()` just
return true for rwNode in replica. then it can't get replica info by
stopping query node and release segment will be blocked.

This PR make `replica.Contains()` return true for both roNode and
rwNode.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 mentioned this issue May 10, 2024
Open
1 task
@weiliu1031
Copy link
Contributor

/assgin @zhuwenxing

@weiliu1031
Copy link
Contributor

please verify this with latest image

weiliu1031 added a commit to weiliu1031/milvus that referenced this issue May 10, 2024
@weiliu1031
fix: Segment on stopping query node can't be release successfully (mi…
ce80213 
…lvus-io#32929)

issue: milvus-io#32901
Cause release segment request need be send to delegator, but it need
replica to info find segment's delegator. but the stopping query node
will be marked as read only in replica, then `replica.Contains()` just
return true for rwNode in replica. then it can't get replica info by
stopping query node and release segment will be blocked.

This PR make `replica.Contains()` return true for both roNode and
rwNode.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 mentioned this issue May 10, 2024
Closed
UnyieldingOrca pushed a commit to UnyieldingOrca/milvus that referenced this issue May 10, 2024
@weiliu1031
fix: Segment on stopping query node can't be release successfully (mi…
6c4c104 
…lvus-io#32929)

issue: milvus-io#32901
Cause release segment request need be send to delegator, but it need
replica to info find segment's delegator. but the stopping query node
will be marked as read only in replica, then `replica.Contains()` just
return true for rwNode in replica. then it can't get replica info by
stopping query node and release segment will be blocked.

This PR make `replica.Contains()` return true for both roNode and
rwNode.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@yanliang567
Copy link
Contributor

/assign @zhuwenxing

@zhuwenxing
Copy link
Contributor Author

verified and fixed in master-20240511-8a9a4219-amd64

@zhuwenxing zhuwenxing reopened this May 27, 2024
@zhuwenxing
Copy link
Contributor Author

failed for v2.4.1 -- > master-20240524-36cbce4d-amd64
failed job: https://qa-jenkins.milvus.io/blue/organizations/jenkins/rolling_update_for_operator_test_simple/detail/rolling_update_for_operator_test_simple/3509/pipeline

log:
artifacts-kafka-mixcoord-3509-server-logs.tar.gz

image

@zhuwenxing
Copy link
Contributor Author

zhuwenxing commented May 27, 2024 •
edited

2.3-latest --> 2.4-latest : pass
v2.4.1 --> 2.4-latest: pass
v2.4.1 --> master-latest: failed

@weiliu1031 weiliu1031 mentioned this issue May 27, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 27, 2024
@weiliu1031
fix: Watch channel task may stuck forever until qn become offline (#3…
6275c75 
…3394)

issue: #32901
pr #32814 introduce the compatible issue, when upgrade to milvus latest,
the query coord may skip update dist due to the lastModifyTs doesn't
changes. but for old version querynode, the lastModifyTs in
GetDataDistritbuionResponse is always 0, which makes qc skip update
dist. then qc will keep retry the task to watch channel again and again.

this PR add compatible with old version querynode, when lastModifyTs is
0, qc will update it's data distribution.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@zhuwenxing
Copy link
Contributor Author

v2.4.1 --> master-20240530-589d4dfd-amd64: pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuwenxing zhuwenxing

@weiliu1031 weiliu1031

Labels
kind/bug Issues or changes related a bug priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
2.4.2
Development

No branches or pull requests
3 participants
@zhuwenxing @yanliang567 @weiliu1031