Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve get_identifier_description testing coverage #31

Open
George3d6 opened this issue Nov 8, 2021 · 1 comment
Open

Improve get_identifier_description testing coverage #31

George3d6 opened this issue Nov 8, 2021 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@George3d6
Copy link

Important logic, we should unittest it with real-world examples and generated data
@George3d6 George3d6 mentioned this issue Nov 8, 2021
Merged
@paxcema
Copy link
Member

paxcema commented Nov 8, 2021

As discussed, may be worth moving some modules in lightwood/helpers/text to a separate "identification" module or similar.

@paxcema paxcema added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 27, 2022
@paxcema paxcema transferred this issue from mindsdb/lightwood Nov 24, 2022
@paxcema paxcema changed the title Test get_identifier_description Improve get_identifier_description testing coverage Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paxcema @George3d6