Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Flatpak in CI #14673

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Build Flatpak in CI #14673

wants to merge 15 commits into from
+114 −0

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented May 16, 2024 •
edited

Fix #14652

To do

This PR is a Work in Progress.

  • Add Flatpak manifest to repository (copied from Flathub with the following fixes)
    • Correct app ID (Rename app flathub/net.minetest.Minetest#5)
    • Enable Wayland support (as a default), only enable X11 as a fallback (since the next version will be SDL2)
    • Use local code (sadly using a git source type for the current directory instead of the dir type doesn't work in CI, which prevents from using CCACHE for the build for some reasons)
    • Add --share=ipc to permissions, apparently (?) it could affect X11 performances
  • Add CI workflow to build the image
  • Add the Flatpak bundle as CI artifact
  • Add GH Attestations support for the bundle (allow to make sure a file comes from the CI workflow and link to the logs)
  • Disable again attestations on pull requests
  • Add some kind of documentation for the attestations?
  • Put the manifest in another directory?
  • More testing

On the used action side, this is a bit concerning (several warnings after run, much much lower performances in upload):

How to test

See workflow runs, read diff.

Try installing the bundle from the artifacts.

@Zughy Zughy added @ Build CMake, build scripts, official builds, compiler and linker errors Feature ✨ PRs that add or enhance a feature Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand. labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Feature ✨ PRs that add or enhance a feature Roadmap: Needs approval The change is not part of the current roadmap and needs to be approved by coredevs beforehand.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Flatpak from GitHub CI
2 participants
@AFCMS @Zughy