Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location of resources folder #163

Open
dhirschfeld opened this issue May 21, 2020 · 3 comments · May be fixed by #860
Open

Location of resources folder #163

dhirschfeld opened this issue May 21, 2020 · 3 comments · May be fixed by #860
Assignees
@mingrammer
Labels
proposal Suggestion proposed status/accepted Accepted proposal

Comments

@dhirschfeld
Copy link

At present it appears that the resources folder is distributed under site-packages/resources rather than site-packages/diagrams/resources.

It seems a bit strange to deploy non-python package data directly to the site-packages folder.

Would there be any objection to a PR which moved the resources folder to site-packages/diagrams/resources?
@dhirschfeld dhirschfeld mentioned this issue May 21, 2020
Merged
5 tasks
@mingrammer
Copy link
Owner

mingrammer commented May 22, 2020 •
edited

It makes sense. It would be nice to make the diagrams folder the project root folder (for package distribution). I'll work on it. Thank you for pointing it.

@mingrammer mingrammer added proposal Suggestion proposed status/accepted Accepted proposal labels May 22, 2020
@mingrammer mingrammer self-assigned this May 22, 2020
@dhirschfeld
Copy link
Author

I'd be happy to work on it but I don't know anything about poetry.

I'd imagine simply putting the resources folder directly under diagrams would do the job but if you wanted to keep the existing source structure it might need some config to put it in the right place.

@mingrammer
Copy link
Owner

mingrammer commented May 22, 2020 •
edited

Yes, just putting the resources folder under diagrams, and update the icon loading method of the Node class. (+ and need to also update the autogen scripts)

@gabriel-tessier gabriel-tessier mentioned this issue Jul 15, 2020
Open
@starcraft66 starcraft66 linked a pull request Feb 27, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mingrammer mingrammer

Labels
proposal Suggestion proposed status/accepted Accepted proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move resources into source folder starcraft66/diagrams
2 participants
@dhirschfeld @mingrammer