Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor common schema directives logic used by make_executable_schema from SchemaDirectiveVisitor #1018

Open
rafalp opened this issue Feb 3, 2023 · 0 comments
Labels
enhancement New feature or request to do

Comments

@rafalp
Copy link
Contributor

rafalp commented Feb 3, 2023

Currently SchemaDirectiveVisitor does two things:

  • Its a base class for custom GraphQL directives.
  • Its a manager class for directives, with visit_schema_directives and get_declared_directives classmethods that make_executable_schema uses to apply directives to the schema

We should introduce new abstraction called SchemaDirective that extends SchemaVisitor, but only adds directive-specific logic, and move management/schema visiting logic to utility functions. SchemaDirectiveVisitor should then be deprecated.

@rafalp rafalp added enhancement New feature or request roadmap Feature that we want to have included labels Feb 3, 2023
@TMuszczekk TMuszczekk added to do and removed roadmap Feature that we want to have included labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to do
Projects
None yet
Development

No branches or pull requests

2 participants