Addition docs adhering PEP257 and PEP8 #11
+382
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the docs ! @alexandresablayrolles will review some time next week. |
I do not see any review there! Do Any change required? |
|
@Sabersaber86 I do not see any reviews over there. |
|
@alexandresablayrolles please review this |
timlacroix
reviewed
Oct 18, 2023
| @@ -21,6 +34,22 @@ def sample_top_p(probs: torch.Tensor, p: float): | |||
|
|
|||
|
|
|||
| def sample(logits: torch.Tensor, temperature: float, top_p: float): | |||
| """ | |||
| Sample from the softmax distribution of logits with optional temperature and top-p filtering. | |||
There was a problem hiding this comment.
tempeatures / top-p aren't optional ?
timlacroix
reviewed
Oct 18, 2023
| model (Transformer): The Transformer model. | ||
| tokenizer (Tokenizer): The tokenizer for encoding and decoding text. | ||
| max_tokens (int): The maximum number of tokens to generate. | ||
| chunk_size (int, optional): The size of chunks for encoding prompts. |
There was a problem hiding this comment.
should fix typing into Optional[int]
timlacroix
reviewed
Oct 18, 2023
| l2 (List[torch.Tensor]): The second list of tensors. | ||
|
|
||
| Returns: | ||
| List[torch.Tensor]: A new list containing elements interleaved from l1 and l2. |
There was a problem hiding this comment.
maybe clarify what interleaving means with an example ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10