Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode documentation navigation issue #14

Open
Kyle-Ye opened this issue Feb 22, 2024 · 3 comments
Open

Xcode documentation navigation issue #14

Kyle-Ye opened this issue Feb 22, 2024 · 3 comments

Comments

@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Feb 22, 2024

We should avoid using hardcoded absolute link in Documentation bundle.

The result is the web version is fine but build and open the documentation in Xcode will give us a bad navigation experience - Opening a new web tab instead of navigating the corresponding page.

Also it will increase the cost when we want to deploy our documentation in other platform other than GitHub page. (eg. SwiftPackageIndex)

@davidkoski
Copy link
Collaborator

Are you referring to the links between the packages? I couldn't figure out any other way to get them -- it looks like the cross package links are still in the future.

We could potentially switch them to relative links. That would fix the hosting issue I think, but not viewing in Xcode docs.

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Feb 22, 2024

Are you referring to the links between the packages? I couldn't figure out any other way to get them -- it looks like the cross package links are still in the future.

Got it. I'm tracking this on the swift-docc side. It is indeed not supported currently on the upstream.

Once we are ready, we'll revisit the issue here.

@davidkoski
Copy link
Collaborator

I think the relative links will work for SPI. I added a .spi.yml file to indicate what to build for SwiftPackageIndex.

I think the remaining issue is the inability to do cross-package links that will work in the Xcode documentation viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants