-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support Short-Time Fourier Transforms #1004
Comments
You can assign this to me. |
Cool.. if we include this, I wonder where it would go? I'm not opposed to including it in core or a sub-package but I think there is a decision to be made there. I see jax implemented it in a Also our Whisper implementation already has an STFT in MLX you might find useful: https://github.com/ml-explore/mlx-examples/blob/main/whisper/whisper/audio.py#L104-L127 |
I think adding them in core is best - they’re fundamental algorithms and used frequently. A separate Thanks for pointing me to the Whisper implementation, I haven't seen in yet |
One tiny issue about I found it a little bit misleading while implementing |
Is it not the same as I think that's a good reference to follow. |
Still working on this CL, shouldn't be much longer.
|
No. According to this In stft in mlx-example/whisper |
Cool. I was implementing a |
Short-Time Fourier Transforms (STFT) and its inverse are used extensively in signal processing.
Function definition will match scipy:
https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.stft.html
https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.istft.html
The text was updated successfully, but these errors were encountered: