Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support pickling array for bfloat16 #795

Open
awni opened this issue Mar 6, 2024 · 7 comments
Open

[Feature] Support pickling array for bfloat16 #795

awni opened this issue Mar 6, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@awni
Copy link
Member

awni commented Mar 6, 2024

Leaving this here in case someone wants to pick it up.

@awni awni added the enhancement New feature or request label Mar 6, 2024
@MacOS
Copy link

MacOS commented Apr 6, 2024

I would be interested.

@awni
Copy link
Member Author

awni commented Apr 8, 2024

Great!! Send a PR?

@MacOS
Copy link

MacOS commented Apr 8, 2024

I will! :)

May I ask you to assign the issue to me so that it appears on my GitHub landing page and reminds me to do it ASAP?

@AvikantSrivastava
Copy link
Contributor

@MacOS are you still working on this? If not I would be happy to take it up :)
cc: @awni

@awni awni assigned AvikantSrivastava and unassigned MacOS Apr 30, 2024
@awni
Copy link
Member Author

awni commented Apr 30, 2024

Go for it @AvikantSrivastava

@AvikantSrivastava
Copy link
Contributor

@awni I was referring to this PR https://github.com/ml-explore/mlx/pull/713/files for the implementation of pickle bindings. It seems that this piece of code was later removed, can you point me to the pickling implementation?

@awni
Copy link
Member Author

awni commented May 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants