Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] system-lib-prefix would be cleared if device is not strictly android while mlc_llm compile #2255

Open
BitCircuit opened this issue Apr 30, 2024 · 2 comments
Labels
bug Confirmed bugs

Comments

@BitCircuit
Copy link

馃悰 Bug

Hi there, thank you so much for your great work. I am new here, sorry if this is silly.
I have met this problem while converting a LLM for a GPU enabled Android device via Python APIs.
While in mlc_llm compile stage, if I set device to android:adreno (I assume it won't invoke Adreno GPU if I simply set it to android, right?), it will trigger this code and clear the system-lib-prefix.
For my own case, I would just comment them out. But in my opinion, this logic does not make sense, and that's why I am submitting this report.

@BitCircuit BitCircuit added the bug Confirmed bugs label Apr 30, 2024
@tqchen
Copy link
Contributor

tqchen commented Apr 30, 2024

passing in android would be fine, and it will invoke adreno GPUs.

@tqchen
Copy link
Contributor

tqchen commented Apr 30, 2024

After reading through the code, i think @BitCircuit you are right and we can safely remove this line, do you mind send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs
Projects
None yet
Development

No branches or pull requests

2 participants