馃殌 Feature: Unify --ignore
and --watch-ignore
and make the patterns recursive
#5131
Open
3 tasks done
Labels
status: in triage
a maintainer should (re-)triage (review) this issue
type: feature
enhancement proposal
Feature Request Checklist
faq
label, but none matched my issue.Overview
Looking at the current behavior of Mocha there is an inconsistency between normal execution and watch execution due to different defaults in
--ignore
and--watch-ignore
.I think many devs will agree that picking up data from the node_modules folder is not in their interest when maintaining any project and running tests.
Additionally the
node_modules
folder might live in a subfolder (mono repos) but still is subject of being ignored. The current pattern only ignoresnode_modules
on the level of the mocharc config file.Suggested Solution
Hence the new default for both options should be similar to:
['**/node_modules/', '**/.git/']
Alternatives
If this is the intended behavior and has a reasoning, this reasoning should be documented on the website.
Additional Info
When using NPM workspaces (common in mono-repos) there will be symlinks from
node_modules
to the directories of the packages. https://docs.npmjs.com/cli/v10/using-npm/workspacesRunning Mocha with
--reporter=json
then shows that rather the tests in the node_modules are picked up than the real working directory.This can lead to further problems when processing the test reports or in case external tooling relies on these paths.
The problem became visible while working on a VS Code Extension and tests from node_modules were listed.
CoderLine/mocha-vscode#1
The text was updated successfully, but these errors were encountered: