Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chokidar #5142

Closed
4 tasks done
simhnna opened this issue May 16, 2024 · 3 comments
Closed
4 tasks done

Bump chokidar #5142

simhnna opened this issue May 16, 2024 · 3 comments
Labels
status: in triage a maintainer should (re-)triage (review) this issue type: bug a defect, confirmed by a maintainer

Comments

@simhnna
Copy link
Contributor

simhnna commented May 16, 2024

Bug Report Checklist

  • I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
  • I have searched for related issues and issues with the faq label, but none matched my issue.
  • I have 'smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, my usage of Mocha, or Mocha itself.
  • I want to provide a PR to resolve this

Expected

works with typescript

Actual

chokidar is incompatible to current @types/node releases
paulmillr/chokidar#1299

Minimal, Reproducible Example

Versions

mocha 10.4.0
@types/node 20.12.11
node 20.12.2

Additional Info

If #5114 was already done this wouldn't be an issue.

I'd just bump chokidar to ^3.6.0

@simhnna simhnna added status: in triage a maintainer should (re-)triage (review) this issue type: bug a defect, confirmed by a maintainer labels May 16, 2024
simhnna added a commit to simhnna/mocha that referenced this issue May 16, 2024
simhnna added a commit to simhnna/mocha that referenced this issue May 21, 2024
@JoshuaKGoldberg
Copy link
Member

Heya thanks for filing! I just marked #5114 as accepting PRs, so let's go with that one instead. That way we don't have to do raise the minimum version of chokidar, as that could arguably be considered a breaking change.

@JoshuaKGoldberg JoshuaKGoldberg closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
@simhnna
Copy link
Contributor Author

simhnna commented May 24, 2024

I don't know why updating chokidar would be considered a breaking change. It's a direct dependency and not a peer dependency so mocha is free to use whatever version without compatibility issues with any other library. Also chokidar seems to be following semver and is so widely used that I doubt any breaking change makes it into a minor/patch release

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 24, 2024

If users happen to have their own dependency on chokidar then changing our version could cause a second version of it to appear in their node_modules. I've in the past been yelled at on the internet about bugs caused by introduced differing package versions.

+1 to your point that it doesn't seem very likely to be a real breaking change 😄. But figuring out whether chokidar version differences could cause these kinds of bugs is something I don't think we need to spend the time on given that #5114 would also solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in triage a maintainer should (re-)triage (review) this issue type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants