Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Add __refitem__ to List #2432

Open
JoeLoser opened this issue Apr 28, 2024 · 7 comments
Open

[stdlib] Add __refitem__ to List #2432

JoeLoser opened this issue Apr 28, 2024 · 7 comments
Labels
mojo-repo Tag all issues with this label mojo-stdlib Tag for issues related to standard library

Comments

@JoeLoser
Copy link
Collaborator

As the TODO suggests, rename __get_ref to be __refitem__. Then, we can remove List.__getitem__. This will require fixing up a bunch of callers that previously were using List.__getitem__ to now dereferenced the returned Reference from List.__refitem__, e.g. my_list[some_index][].

@StandinKP
Copy link

I can take this up @JoeLoser

@JoeLoser
Copy link
Collaborator Author

I can take this up @JoeLoser

I appreciate the enthusiasm, but unfortunately this one may be blocked on #2441 as @mikowals started taking a look at this I think.

@JoeLoser
Copy link
Collaborator Author

Blocked by #2441

@JoeLoser JoeLoser added blocked Blocked by another issue that must be resolved first and removed good first issue Good for newcomers labels Apr 29, 2024
@StandinKP
Copy link

No problem. LMK if I should take up anything on priority or I can browse through some of the older issues and pick sth up @JoeLoser

@JoeLoser
Copy link
Collaborator Author

No problem. LMK if I should take up anything on priority or I can browse through some of the older issues and pick sth up @JoeLoser

Will certainly do! I'm planning on adding several GitHub issues to the public repo this week, so stay tuned 😄

@StandinKP
Copy link

Perfect🔥

@JoeLoser JoeLoser removed the blocked Blocked by another issue that must be resolved first label Apr 29, 2024
@JoeLoser
Copy link
Collaborator Author

JoeLoser commented Apr 29, 2024

Removed blocked label since it appears to have been a user error. See my comment at #2441 (comment).

@ematejska ematejska removed the mojo-stdlib Tag for issues related to standard library label May 3, 2024
@ematejska ematejska added the mojo-stdlib Tag for issues related to standard library label May 3, 2024 — with Linear
@ematejska ematejska removed the mojo-stdlib Tag for issues related to standard library label May 6, 2024
@ematejska ematejska added the mojo-stdlib Tag for issues related to standard library label May 6, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mojo-repo Tag all issues with this label mojo-stdlib Tag for issues related to standard library
Projects
None yet
Development

No branches or pull requests

4 participants