Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add ducktyping between traits #2476

Open
1 task done
martinvuyk opened this issue May 3, 2024 · 0 comments
Open
1 task done

[Feature Request] add ducktyping between traits #2476

martinvuyk opened this issue May 3, 2024 · 0 comments
Labels
enhancement New feature or request mojo-repo Tag all issues with this label

Comments

@martinvuyk
Copy link

martinvuyk commented May 3, 2024

Review Mojo's priorities

What is your request?

if the trait defines all of the methods needed that are defined in another trait definition, then the compiler should accept it

What is your motivation for this change?

I was trying to implement an interface to sort and sorted similar to python's

trait ComparableCollectable:
    fn __copyinit__(inout self: Self, existing: Self):
        ...

    fn __moveinit__(inout self: Self, owned existing: Self):
        ...

    fn __del__(owned self: Self):
        ...

    fn __eq__(self: Self, other: Self) -> Bool:
        ...

    fn __ne__(self: Self, other: Self) -> Bool:
        ...

    fn __lt__(self: Self, other: Self) -> Bool:
        ...

    fn __le__(self: Self, other: Self) -> Bool:
        ...

    fn __gt__(self: Self, other: Self) -> Bool:
        ...

    fn __ge__(self: Self, other: Self) -> Bool:
        ...


# when trait declarations do support parameters
#
# trait Collection[T: ComparableCollectable, A: KeyElement]:
#     fn __getitem__(self: Self, i: A) -> T:
#         ...
#     fn __setitem__(self: Self, i: A) -> T:
#         ...
#
# that way key could be
# key: fn (Collection[T], KeyElement) -> T = List[T].__getitem__
# where for List, Set, Tuple, et al.  KeyElement is of type Int


@always_inline
fn _swap[T: ComparableCollectable](inout buf: List[T], a: Int, b: Int):
    var tmp = buf[a]
    buf[a] = buf[b]
    buf[b] = tmp


@always_inline
fn _partition[
    T: ComparableCollectable, key: fn (List[T], Int) -> T = List[T].__getitem__
](inout buf: List[T], low: Int, high: Int) -> Int:
    var pivot = key(buf, high)
    var i = low - 1
    for j in range(low, high):
        if key(buf, j) <= pivot:
            i += 1
            _swap(buf, i, j)
    _swap(buf, i + 1, high)
    return i + 1


fn _qsort[
    T: ComparableCollectable, key: fn (List[T], Int) -> T = List[T].__getitem__
](inout buf: List[T], low: Int, high: Int):
    if low < high:
        var pi = _partition[T, key](buf, low, high)
        _qsort(buf, low, pi - 1)
        _qsort(buf, pi + 1, high)


fn qsort[
    T: ComparableCollectable, key: fn (List[T], Int) -> T = List[T].__getitem__
](inout buf: List[T]):
    _qsort[T, key](buf, 0, len(buf) - 1)


fn sort[
    T: ComparableCollectable,
    max_size: Int = 999,
    key: fn (List[T], Int) -> T = List[T].__getitem__,
](inout buf: List[T]):
    if max_size == 3:
        # TODO: AlphaDev sort3..sort8
        pass
    elif False:  # type: ignore
        # TODO: other algos
        pass
    else:
        qsort(buf)


fn sorted[
    T: ComparableCollectable,
    max_size: Int = 999,
    key: fn (List[T], Int) -> T = List[T].__getitem__,
](owned buf: List[T]) -> List[T]:
    sort[T, max_size, key](buf)
    return buf


fn main():
    var items = List[Int](2, 3, 4, 5, 1, 9, 8, 7, 0)
    print(sorted(items))

Any other details?

This might also count as a proposal for adding builtin sort and sorted functions #2390

@martinvuyk martinvuyk added enhancement New feature or request mojo-repo Tag all issues with this label labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mojo-repo Tag all issues with this label
Projects
None yet
Development

No branches or pull requests

1 participant