You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the streamlit app, school not plotted in map, only centers are plotted. I believe the original intent of this feature was to visualize how the centers are geo - distributed with respect to the school (and vice versa), omitting selected school defeats the purpose.
Steps to reproduce
Run the streamlit app, select a school or center, observe only centers are plotted, not the selected entity
Describe what you expected to happen.
Schools should also be plotted in a different colored marker.
similar to what @RupeshAryal had demoed in this comment
Additionally -
make the list serial number start from 1
remove thousand separator in scode / cscode
personal opinion - markers used by in demo above looks better
Put here any screenshots or videos (optional)
When school is selected, it is not plotted
When center is selected, it is the only thing plotted.
Environment
Linux
python 3.11.9
Firefox 125
Would you like to work on this issue?
None
Acknowledgements
My issue title is concise, descriptive.
I searched the existing issues to ensure this bug hasn't been reported.
I am using the latest version of repo.
I have provided enough information for the maintainers to reproduce and diagnose the issue.
The text was updated successfully, but these errors were encountered:
Few additional features have been added in the codebase and improvise in the readability of streamlit codebase
1) Schools will now be plotted on the map alongside centers, using a different colored marker.
2) The list serial number now starts from 1 instead of 0.
- In "filter_data" function, when filtering the DataFrame based on the selected type and value, the filter was being applied directly to the DataFrame without resetting the index.
3) Removed thousand separators from scode and cscode.
4) Changed the marker style for better aesthetics.
0xSolidityWeb3
added a commit
to 0xSolidityWeb3/center-randomize
that referenced
this issue
May 7, 2024
* Fixes of Schools are not plotted in map in streamlit app
* Fetch Schools Latitude,Logitude from session rather than fetching data from given school's sample_data
* Use School List instead of fetching lat,long,scode from school-center-distance and use dataframe in tab3 instead of re-reading from tsv file
---------
Co-authored-by: nirmala.sharma <nirmala.sharma@imark.com.np>
Description
Updated description May 5, 2024
In the streamlit app, school not plotted in map, only centers are plotted. I believe the original intent of this feature was to visualize how the centers are geo - distributed with respect to the school (and vice versa), omitting selected school defeats the purpose.
Steps to reproduce
Run the streamlit app, select a school or center, observe only centers are plotted, not the selected entity
Describe what you expected to happen.
Schools should also be plotted in a different colored marker.
similar to what @RupeshAryal had demoed in this comment
Additionally -
Put here any screenshots or videos (optional)
When school is selected, it is not plotted
When center is selected, it is the only thing plotted.
Environment
Linux
python 3.11.9
Firefox 125
Would you like to work on this issue?
None
Acknowledgements
The text was updated successfully, but these errors were encountered: