-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add support for renovate bot #970
Comments
@prabirshrestha I'm not very familiar with renovate. What would it do with |
I mean When I get PRs like these it only updates package.json instead of moon.yml. prabirshrestha/moonrepo-rust-vite-template#10 - "packageManager": "pnpm@8.6.5",
+ "packageManager": "pnpm@8.6.7", "engines": {
- "node": "18.16.0"
+ "node": "18.16.1"
}
node:
version: '18.16.0'
packageManager: 'pnpm'
pnpm:
version: '8.6.5' |
Just spotted this, which would block our adoption. Unfortunately we use Renovate's hosted offering on GitHub, rather than their self-hosted version, so the workaround mentioned above doesn't work for our use case. I've started a discussion over on the Renovate repo for anybody else tracking this. |
Renovate have responded requesting we copy/paste their template into the aforementioned discussion thread on their repo, and fill it out in full. I'm not sure I know enough about Moon at this point to do that, but if someone with more knowledge could pick this up I'd be grateful. |
The other workaround is to use https://github.com/prabirshrestha/synology-nomad/blob/a1e955b7825b115ba1061e2c66dbf363a6e53370/renovate.json#L6-L13 Would be great if someone can try it for moon. Though I would still love to have an official support in renovate for moon. |
I don't have time to work on this myself, and I never use renovate. But if someone wants to tackle it, I can answer any questions you may have in the Discord. |
I have got this working with custom renovate.json{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base"
],
"packageRules": [
{
"matchPackagePatterns": ["@adobe/*", "@react-spectrum/*", "@spectrum-icons/*", "@react-types/", "react-aria-components"],
"groupName": "react-spectrum"
},
{
"matchPackagePatterns": ["cornerstone-*", "dicom-parser", "hammerjs", "react-cornerstone-viewport", "@types/cornerstone-*", "@types/hammerjs"],
"groupName": "dicom-cornerstone"
},
{
"matchPackagePatterns": ["video.js", "videojs-*", "@types/video.js"],
"groupName": "videojs"
},
{
"matchPackageNames": ["node", "@types/node", "nodejs/node"],
"groupName": "Node.js"
}
],
"regexManagers": [
{
"fileMatch": [
"^.moon\/.*\.ya?ml$",
"^.github\/workflows\/.*\.ya?ml$",
"^.prototools$"
],
"matchStrings": [
".*?(:|=)\\s+('|\\\")(=?)(?<currentValue>.*)('|\\\")\\s+#\\s+renovate: datasource=(?<datasource>.+?) depName=(?<depName>.+?)( versioning=(?<versioning>.*?))?( extractVersion=(?<extractVersion>.*?))?\\n"
]
},
{
"fileMatch": ["^rust-toolchain\\.toml$"],
"matchStrings": [
"channel\\s*=\\s*\"(?<currentValue>\\d+\\.\\d+(\\.\\d+)?)\""
],
"depNameTemplate": "rust-lang/rust",
"lookupNameTemplate": "rust-lang/rust",
"datasourceTemplate": "github-releases"
}
]
} rustUpdate moonUpdate update update protoUpdate nodejsUpdate As you can see the moon configs now auto syncs with appropriate files when renovatebot detects a new dependency. Renovatebot allows us to run custom task. What moon needs is |
One thing I have noticed when configuring rennovate bot is that I get PRs to update package.json version for pnpm but not for moon.yml. Probably worth adding official support for moon in renovate bot. In the meantime another workaround would be to allow custom update via https://docs.renovatebot.com/configuration-options/#postupgradetasks.
The text was updated successfully, but these errors were encountered: