Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Access-Control-Max-Age to CORS headers #2057

Closed
wants to merge 1 commit into from
Closed

Added Access-Control-Max-Age to CORS headers #2057

wants to merge 1 commit into from

Conversation

Bnux256
Copy link

@Bnux256 Bnux256 commented Jul 10, 2022 •
edited by djmattyg007

Added "Access-Control-Max-Age" to CORS headers (using: "self.set_header("Access-Control-Max-Age", "86400")). Now preflight requests can be cached on the browser. This resolves #2043.

@djmattyg007 djmattyg007 changed the title Added Access-Control-Max-Age to CROS headers Added Access-Control-Max-Age to CORS headers Jul 10, 2022
@Bnux256 Bnux256 marked this pull request as ready for review July 11, 2022 07:12
@Bnux256 Bnux256 closed this by deleting the head repository Sep 26, 2022
@kingosticks
Copy link
Member

Was this broken?

@Bnux256
Copy link
Author

Bnux256 commented Sep 28, 2022

No, it worked great locally, preflight requests are cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set "Access-Control-Max-Age" CORS header to avoid preflighting every request
2 participants
@Bnux256 @kingosticks